kamkow1/my-os-project2
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Spinlock fix small race window

Browse Source
This commit is contained in:
Kamil Kowalczyk
2025-11-18 23:28:11 +01:00
parent 28c95303e9
commit 88f9d0e3d4
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/spinlock/spinlock.c
View File

@ -17,7 +17,7 @@ void spinlock_init(SpinLock *sl) {
uint64_t irqsave(void) { uint64_t irqsave(void) {
uint64_t flags; uint64_t flags;
asm volatile("pushfq; cli; popq %0" : "=r"(flags) :: "memory", "cc"); asm volatile("pushfq; popq %0; cli" : "=r"(flags) :: "memory", "cc");
return flags; return flags;
} }
@ -43,7 +43,6 @@ void irqrestore_nested(void) {
void spinlock_acquire(SpinLock *sl) { void spinlock_acquire(SpinLock *sl) {
irqsave_nested(); irqsave_nested();
while (atomic_test_and_set_explicit(&sl->lock, memory_order_acquire)) { while (atomic_test_and_set_explicit(&sl->lock, memory_order_acquire)) {
SPINLOCK_HINT(); SPINLOCK_HINT();
} }