kamkow1/mop3
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't modify proc_tree while iterating

Browse Source
This commit is contained in:
Kamil Kowalczyk
2026-02-22 00:47:53 +01:00
parent 389f250d0b
commit b571e2dbd3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/proc/proc.c
View File

@@ -232,7 +232,6 @@ static void proc_reap (struct reschedule_ctx* rctx) {
if (atomic_load (&proc->state) == PROC_DEAD) { if (atomic_load (&proc->state) == PROC_DEAD) {
spin_lock (&proc->lock); spin_lock (&proc->lock);
rbtree_delete (&proc_tree, &proc->proc_tree_link);
list_append (reap_list, &proc->reap_link); list_append (reap_list, &proc->reap_link);
spin_unlock (&proc->lock); spin_unlock (&proc->lock);
} }
@@ -245,7 +244,7 @@ static void proc_reap (struct reschedule_ctx* rctx) {
struct list_node_link *reap_link, *reap_link_tmp; struct list_node_link *reap_link, *reap_link_tmp;
list_foreach (reap_list, reap_link, reap_link_tmp) { list_foreach (reap_list, reap_link, reap_link_tmp) {
proc = list_entry (reap_link, struct proc, reap_link); proc = list_entry (reap_link, struct proc, reap_link);
rbtree_delete (&proc_tree, &proc->proc_tree_link);
list_remove (reap_list, &proc->reap_link); list_remove (reap_list, &proc->reap_link);
DEBUG ("cleanup PID %d\n", proc->pid); DEBUG ("cleanup PID %d\n", proc->pid);
proc_cleanup (proc, rctx); proc_cleanup (proc, rctx);