XDRV_READ reading in sectors

kernel/device/device.c

@@ -2,6 +2,7 @@
 #include <device/ramdrv.h>
 #include <device/terminal.h>
 #include <kb_device.h>
+#include <libk/align.h>
 #include <libk/fieldlengthof.h>
 #include <libk/rbtree.h>
 #include <libk/std.h>

kernel/device/ramdrv.c

@@ -1,9 +1,11 @@
 #include <device/device.h>
 #include <device/ramdrv.h>
+#include <libk/align.h>
 #include <libk/std.h>
 #include <libk/string.h>
 #include <mm/liballoc.h>
 #include <status.h>
+#include <sys/debug.h>
 #include <xdrv_device.h>
 
 bool ramdrv_init (struct device* device, void* arg) {
@@ -14,23 +16,21 @@ bool ramdrv_init (struct device* device, void* arg) {
   if (ramdrv == NULL)
     return false;
 
-  ramdrv->total_size = init->total_size;
   ramdrv->sector_size = init->sector_size;
+  ramdrv->total_size = align_up (init->total_size, ramdrv->sector_size);
 
-  if (init->buffer == NULL) {
-    ramdrv->buffer = malloc (init->total_size);
+  ramdrv->buffer = malloc (ramdrv->total_size);
 
-    if (ramdrv->buffer == NULL) {
-      free (ramdrv);
-      return false;
-    }
-
-    ramdrv->managed = false;
-  } else {
-    ramdrv->buffer = init->buffer;
-    ramdrv->managed = true;
+  if (ramdrv->buffer == NULL) {
+    free (ramdrv);
+    return false;
   }
 
+  memset (ramdrv->buffer, 0, ramdrv->total_size);
+
+  if (init->buffer != NULL)
+    memcpy (ramdrv->buffer, init->buffer, init->total_size);
+
   device->udata = ramdrv;
 
   return true;
@@ -39,8 +39,8 @@ bool ramdrv_init (struct device* device, void* arg) {
 void ramdrv_fini (struct device* device) {
   struct ramdrv* ramdrv = device->udata;
 
-  if (!ramdrv->managed)
-    free (ramdrv);
+  free (ramdrv->buffer);
+  free (ramdrv);
 }
 
 int ramdrv_get_device_type (struct device* device, struct proc* proc, struct reschedule_ctx* rctx,
@@ -91,19 +91,16 @@ int ramdrv_get_sector_size (struct device* device, struct proc* proc, struct res
 
 int ramdrv_read (struct device* device, struct proc* proc, struct reschedule_ctx* rctx, void* a1,
                  void* a2, void* a3, void* a4) {
-  (void)a4;
-
-  if (a1 == NULL || a2 == NULL || a3 == NULL)
+  if (a1 == NULL || a2 == NULL || a3 == NULL || a4 == NULL)
     return -ST_BAD_ADDRESS_SPACE;
 
-  size_t pos = *(size_t*)a1;
-  size_t size = *(size_t*)a2;
-  uint8_t* buffer = a3;
+  size_t sector = *(size_t*)a1;
+  size_t off = *(size_t*)a2;
+  size_t size = *(size_t*)a3;
+  uint8_t* buffer = a4;
 
   struct ramdrv* ramdrv = device->udata;
-
-  if (pos + size > ramdrv->total_size)
-    return -ST_OOB_ERROR;
+  size_t pos = sector * ramdrv->sector_size + off;
 
   memcpy (buffer, (void*)(((uintptr_t)ramdrv->buffer) + pos), size);
 

kernel/device/ramdrv.h

@@ -19,7 +19,6 @@ struct ramdrv {
   size_t total_size;
   size_t sector_size;
   uint8_t* buffer;
-  bool managed;
 };
 
 bool ramdrv_init (struct device* device, void* arg);