Binary release v2.3.1

Makefile

@@ -4,7 +4,6 @@ OBJCOPY = objcopy
 PREFIX = /usr/local
 DESTDIR =
 
-OBJCOPY_ARCH = default
 LIMINE_HDD_BIN = limine-hdd.bin
 BUILD_DIR = $(shell realpath .)
 
@@ -15,22 +14,18 @@ CFLAGS = -O2 -pipe -Wall -Wextra
 all: limine-install
 
 install: all
-	install -d $(DESTDIR)$(PREFIX)/bin
+	install -d "$(DESTDIR)$(PREFIX)/bin"
-	install -s limine-install $(DESTDIR)$(PREFIX)/bin/
+	install -s limine-install "$(DESTDIR)$(PREFIX)/bin/"
-	install -d $(DESTDIR)$(PREFIX)/share
+	install -d "$(DESTDIR)$(PREFIX)/share"
-	install -d $(DESTDIR)$(PREFIX)/share/limine
+	install -d "$(DESTDIR)$(PREFIX)/share/limine"
-	install -m 644 limine.sys $(DESTDIR)$(PREFIX)/share/limine/
+	install -m 644 limine.sys "$(DESTDIR)$(PREFIX)/share/limine/"
-	install -m 644 limine-cd.bin $(DESTDIR)$(PREFIX)/share/limine/
+	install -m 644 limine-cd.bin "$(DESTDIR)$(PREFIX)/share/limine/"
-	install -m 644 limine-eltorito-efi.bin $(DESTDIR)$(PREFIX)/share/limine/
+	install -m 644 limine-eltorito-efi.bin "$(DESTDIR)$(PREFIX)/share/limine/"
-	install -m 644 limine-pxe.bin $(DESTDIR)$(PREFIX)/share/limine/
+	install -m 644 limine-pxe.bin "$(DESTDIR)$(PREFIX)/share/limine/"
-	install -m 644 BOOTX64.EFI $(DESTDIR)$(PREFIX)/share/limine/
+	install -m 644 BOOTX64.EFI "$(DESTDIR)$(PREFIX)/share/limine/"
 
 clean:
-	rm -f limine-hdd.o limine-install limine-install.exe
+	rm -f limine-install limine-install.exe
 
-limine-install: limine-install.c limine-hdd.o
+limine-install: limine-install.c inc.S $(LIMINE_HDD_BIN)
-	$(CC) $(CFLAGS) -std=c11 $^ -o $@
+	$(CC) $(CFLAGS) -std=c11 -DLIMINE_HDD_BIN='"$(LIMINE_HDD_BIN)"' limine-install.c inc.S -o $@
-
-limine-hdd.o: $(LIMINE_HDD_BIN)
-	cd `dirname $^` && \
-	  $(OBJCOPY) -B i8086 -I binary -O $(OBJCOPY_ARCH) `basename $^` $(BUILD_DIR)/$@

inc.S

@@ -0,0 +1,29 @@
+
+#if defined (__APPLE__)
+
+.data
+.global __binary_limine_hdd_bin_start
+__binary_limine_hdd_bin_start:
+    .incbin LIMINE_HDD_BIN
+.global __binary_limine_hdd_bin_end
+__binary_limine_hdd_bin_end:
+
+#elif defined (__MINGW32__)
+
+.section .data
+.global __binary_limine_hdd_bin_start
+__binary_limine_hdd_bin_start:
+    .incbin LIMINE_HDD_BIN
+.global __binary_limine_hdd_bin_end
+__binary_limine_hdd_bin_end:
+
+#elif defined (__linux__) || defined (__unix__)
+
+.section .data
+.global _binary_limine_hdd_bin_start
+_binary_limine_hdd_bin_start:
+    .incbin LIMINE_HDD_BIN
+.global _binary_limine_hdd_bin_end
+_binary_limine_hdd_bin_end:
+
+#endif

limine-install.c

@@ -261,23 +261,13 @@ static bool _device_write(const void *buffer, uint64_t loc, size_t count) {
             goto cleanup;                       \
     } while (0)
 
-#ifdef __MINGW32__
-extern uint8_t binary_limine_hdd_bin_start[], binary_limine_hdd_bin_end[];
-#else
 extern uint8_t _binary_limine_hdd_bin_start[], _binary_limine_hdd_bin_end[];
-#endif
 
 int main(int argc, char *argv[]) {
     int      ok = 1;
-#ifdef __MINGW32__
-    uint8_t *bootloader_img = binary_limine_hdd_bin_start;
-    size_t   bootloader_file_size =
-        (size_t)binary_limine_hdd_bin_end - (size_t)binary_limine_hdd_bin_start;
-#else
     uint8_t *bootloader_img = _binary_limine_hdd_bin_start;
     size_t   bootloader_file_size =
         (size_t)_binary_limine_hdd_bin_end - (size_t)_binary_limine_hdd_bin_start;
-#endif
     uint8_t  orig_mbr[70], timestamp[6];
 
     if (sizeof(off_t) != 8) {
@@ -421,7 +411,7 @@ int main(int argc, char *argv[]) {
             fprintf(stderr, "GPT partition NOT specified. Attempting GPT embedding.\n");
 
             ssize_t max_partition_entry_used = -1;
-            for (ssize_t i = 0; i < gpt_header.number_of_partition_entries; i++) {
+            for (ssize_t i = 0; i < (ssize_t)gpt_header.number_of_partition_entries; i++) {
                 struct gpt_entry gpt_entry;
                 device_read(&gpt_entry,
                     (gpt_header.partition_entry_lba * lb_size)